Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove UserResponder (DEV-3291) #3217

Merged
merged 3 commits into from
Apr 26, 2024
Merged

refactor: Remove UserResponder (DEV-3291) #3217

merged 3 commits into from
Apr 26, 2024

Conversation

mpro7
Copy link
Collaborator

@mpro7 mpro7 commented Apr 25, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@mpro7 mpro7 changed the title remove UserResponder refactor: Remove UserResponder Apr 25, 2024
@mpro7 mpro7 self-assigned this Apr 25, 2024
@mpro7 mpro7 marked this pull request as ready for review April 25, 2024 10:54
@seakayone seakayone changed the title refactor: Remove UserResponder refactor: Remove UserResponder (DEV-3291) Apr 25, 2024
@linear Linear
Copy link

linear bot commented Apr 25, 2024

DEV-3291 Remove the `UsersResponder`

@seakayone
Copy link
Collaborator

praise: Nice one, thanks.

siers
siers approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing.

@mpro7 mpro7 enabled auto-merge (squash) April 26, 2024 06:37
@mpro7 mpro7 merged commit f2f08b3 into main Apr 26, 2024
11 checks passed
@mpro7 mpro7 deleted the remove-users-responder branch April 26, 2024 06:54
@daschbot daschbot mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seakayone seakayone seakayone approved these changes

@siers siers siers approved these changes

@BalduinLandolt BalduinLandolt Awaiting requested review from BalduinLandolt BalduinLandolt is a code owner

Assignees

@mpro7 mpro7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mpro7 @seakayone @siers