New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: partOf and sequenceOf properties are not marked as isEditable #2268
fix!: partOf and sequenceOf properties are not marked as isEditable #2268
Conversation
✅ Linked to Bug DEV-1439 · DSP-API: isEditable property for isSequenceOfValue is returned as false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just haven't understood why isEditable
now needs to be set to true. Wouldn't that mean that users can edit knora-base properties - which should not be the case? (I am sure that you did it right, I just want to understand :)
@@ -561,6 +561,7 @@ | |||
rdfs:comment "Indicates that this resource is part of another resource"@en ; | |||
:subjectClassConstraint :Resource ; | |||
:objectClassConstraint :Resource ; | |||
:isEditable true ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I think I don't understand why here everything is set to :isEditable
true
. Shouldn't knora-base
things not be editable?
Well... I suppose Does that make it clearer? |
Yes, thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few questions, if isSequenceOf
is only used for audio/video, then shouldn't :objectClassConstraint
be :Representation
instead of :Resource
?
Yes and no: It's the same with This could of course be changed, but then we have to check the DB for other usages |
Codecov ReportBase: 86.85% // Head: 86.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2268 +/- ##
==========================================
+ Coverage 86.85% 86.91% +0.05%
==========================================
Files 241 242 +1
Lines 27967 28062 +95
==========================================
+ Hits 24292 24390 +98
+ Misses 3675 3672 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Issue Number: DEV-1439
Pull Request Checklist
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR introduces changes to knora-base, which requires an upgrade script to run, so it needs to be marked as breaking. However, it does not change any public API or break existing code.
Does this PR change client-test-data?
Other information