New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Value update or deletion doesn't work for properties of other ontology (DEV-1367) #2222
fix: Value update or deletion doesn't work for properties of other ontology (DEV-1367) #2222
Conversation
…operties-of-other-ontology
…-other-ontology' of https://github.com/dasch-swiss/dsp-api into wip/dev-1367-value-update-doesnt-work-for-properties-of-other-ontology
This reverts commit 405e88e.
Codecov ReportBase: 86.64% // Head: 86.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2222 +/- ##
==========================================
+ Coverage 86.64% 86.86% +0.22%
==========================================
Files 233 241 +8
Lines 28020 27974 -46
==========================================
+ Hits 24277 24299 +22
+ Misses 3743 3675 -68
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I made two cosmetic remarks, but I don't think they warrant waiting for another test run to pass, so feel free to ignore them.
webapi/src/main/scala/org/knora/webapi/store/cache/impl/CacheServiceInMemImpl.scala
Outdated
Show resolved
Hide resolved
…operties-of-other-ontology
Issue Number: DEV-1367
Pull Request Checklist
Basic Requirements
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR change client-test-data?
Other information