Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve validation of GUI elements and GUI attributes (DEV-1082) #2098

Merged
merged 33 commits into from Jul 29, 2022

Commits on Jul 18, 2022

  1. validate value type of gui attribute

    irinaschubert committed Jul 18, 2022
    Copy the full SHA
    71b8e31 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. improve formatting of salsah-gui.md

    irinaschubert committed Jul 19, 2022
    Copy the full SHA
    b1621ff View commit details
    Browse the repository at this point in the history
  2. small improvements

    irinaschubert committed Jul 19, 2022
    Copy the full SHA
    55aa3db View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. improve error handling

    irinaschubert committed Jul 20, 2022
    Copy the full SHA
    8cb55bd View commit details
    Browse the repository at this point in the history
  2. return multiple validation errors

    irinaschubert committed Jul 20, 2022
    Copy the full SHA
    3ff6e70 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. add validation for all gui elements and gui attributes

    irinaschubert committed Jul 21, 2022
    Copy the full SHA
    2c67113 View commit details
    Browse the repository at this point in the history
  2. organize imports

    irinaschubert committed Jul 21, 2022
    Copy the full SHA
    629f52e View commit details
    Browse the repository at this point in the history
  3. test value types

    irinaschubert committed Jul 21, 2022
    Copy the full SHA
    8634e8f View commit details
    Browse the repository at this point in the history
  4. handle gui element of None

    irinaschubert committed Jul 21, 2022
    Copy the full SHA
    35ae562 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'main' into wip/dev-1082-explore-newtypes

    irinaschubert committed Jul 21, 2022
    Copy the full SHA
    74c502e View commit details
    Browse the repository at this point in the history
  6. simplify code

    irinaschubert committed Jul 21, 2022
    Copy the full SHA
    ee0fa52 View commit details
    Browse the repository at this point in the history
  7. add more tests

    irinaschubert committed Jul 21, 2022
    Copy the full SHA
    8286534 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2022

  1. move tests

    irinaschubert committed Jul 25, 2022
    Copy the full SHA
    58c9956 View commit details
    Browse the repository at this point in the history
  2. remove old value objects

    irinaschubert committed Jul 25, 2022
    Copy the full SHA
    3147382 View commit details
    Browse the repository at this point in the history
  3. update test data

    irinaschubert committed Jul 25, 2022
    Copy the full SHA
    ecee76d View commit details
    Browse the repository at this point in the history
  4. update test data comments

    irinaschubert committed Jul 25, 2022
    Copy the full SHA
    eaf3190 View commit details
    Browse the repository at this point in the history
  5. add more validation for hlist gui attribute value

    irinaschubert committed Jul 25, 2022
    Copy the full SHA
    b5629f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2022

  1. Merge branch 'main' into wip/dev-1082-explore-newtypes

    irinaschubert committed Jul 26, 2022
    Copy the full SHA
    9ae9498 View commit details
    Browse the repository at this point in the history
  2. clean up constants

    irinaschubert committed Jul 26, 2022
    Copy the full SHA
    69fe44c View commit details
    Browse the repository at this point in the history
  3. clean up naming of imports

    irinaschubert committed Jul 26, 2022
    Copy the full SHA
    643f8fe View commit details
    Browse the repository at this point in the history
  4. move uriValidator

    irinaschubert committed Jul 26, 2022
    Copy the full SHA
    fb1f89c View commit details
    Browse the repository at this point in the history
  5. move expected gui attributes to global variable

    irinaschubert committed Jul 26, 2022
    Copy the full SHA
    9699405 View commit details
    Browse the repository at this point in the history
  6. refactor gui attribute map

    irinaschubert committed Jul 26, 2022
    Copy the full SHA
    2ade669 View commit details
    Browse the repository at this point in the history
  7. remove remnants of old salsah gui validation

    irinaschubert committed Jul 26, 2022
    Copy the full SHA
    328be49 View commit details
    Browse the repository at this point in the history
  8. use subtype for password strength

    irinaschubert committed Jul 26, 2022
    Copy the full SHA
    97bbb7a View commit details
    Browse the repository at this point in the history
  9. remove unused value

    irinaschubert committed Jul 26, 2022
    Copy the full SHA
    5e36789 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Merge branch 'main' into wip/dev-1082-explore-newtypes

    irinaschubert committed Jul 27, 2022
    Copy the full SHA
    2938331 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. fix docstrings in UserRepo

    irinaschubert committed Jul 28, 2022
    Copy the full SHA
    42a2ebd View commit details
    Browse the repository at this point in the history
  2. implement feedback from PR review

    irinaschubert committed Jul 28, 2022
    Copy the full SHA
    9fb964e View commit details
    Browse the repository at this point in the history
  3. Merge branch 'main' into wip/dev-1082-explore-newtypes

    irinaschubert committed Jul 28, 2022
    Copy the full SHA
    4d4abef View commit details
    Browse the repository at this point in the history
  4. Fix wrong value

    irinaschubert committed Jul 28, 2022
    Copy the full SHA
    324e833 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'wip/dev-1082-explore-newtypes' of https://github.com/da…

    …sch-swiss/dsp-api into wip/dev-1082-explore-newtypes
    irinaschubert committed Jul 28, 2022
    Copy the full SHA
    7193b57 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2022

  1. return multiple errors in route

    irinaschubert committed Jul 29, 2022
    Copy the full SHA
    3943f2e View commit details
    Browse the repository at this point in the history