New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cacheservice): use ZIO (DEV-546) #2022
Merged
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
c603d38
refactor(cache): remove service from name
subotic 0a5d5a2
refactor(cacheservice): inmem (ongoing)
subotic 001d594
refactor(cacheservice): inmem (ongoing)
subotic 72e7c3f
Merge branch 'main' into wip/DEV-546-zio-fying-cache-service
subotic 10277b8
chore(docs): add structurizr (c4)
subotic ba36160
refactor(cache): inmem get user
subotic 56c9e03
Merge branch 'wip/DEV-546-zio-fying-cache-service' of github.com:dasc…
subotic 9b11fde
Merge branch 'main' into wip/DEV-546-zio-fying-cache-service
subotic d89d667
refactor(cacheservice): in-mem version
subotic 4ef9efd
refactor(cacheservice): redis version (ongoing)
subotic 9340f21
refactor(cacheservice): add zio-config (ongoing)
subotic 82376c2
refactor(cacheservice): redis implementation (ongoing)
subotic 52188ea
Merge branch 'main' into wip/DEV-546-zio-fying-cache-service
subotic bb54fad
refactor(cacheservice): redis implementation (ongoing)
subotic f7c1938
refactor(cacheservice): redis implementation (ongoing)
subotic e56f9f2
refactor(cacheservice): add redis implementation
subotic 99f9739
refactor(cacheservice): add redis serialization implementation (ongoing)
subotic 90b8672
refactor: after spartan session (ongoing)
subotic 8114fa1
refactor(cacheservice): remove actor
subotic 6cb9c9b
refactor(cacheservice): fix tests (ongoing)
subotic fc74215
Merge branch 'main' into wip/DEV-546-zio-fying-cache-service
subotic 39d0ec6
build: fix after merge
subotic 59abb36
refactor(cacheservice): fix tests
subotic c2514ec
Merge branch 'main' into wip/DEV-546-zio-fying-cache-service
subotic df916c6
refactor(cacheservice): add Redis Testcontainers layer
subotic 6805d68
refactor(cacheservice): moving runtime initialization to main
subotic e7606f0
refactor(cacheservice): moving runtime initialisation back where it was
subotic faa6ffd
docs: add ADR record
subotic 9f9e7d5
chore(deps): bump zio libraries
subotic d2cbf3f
Merge branch 'main' into wip/DEV-546-zio-fying-cache-service
subotic 3e20985
chore(deps): bump zio libraries
subotic 1275169
chore(deps): bump zio libraries
subotic aeb14d7
chore: remove unneeded file
subotic 578f837
Merge branch 'main' into wip/DEV-546-zio-fying-cache-service
subotic 97fcb82
refactor(cacheservice): ziofy redis testcontainers
subotic fa23c2d
cleanup
subotic 12ae1e8
fix redis test container
subotic c633f10
fix redis test container
subotic c3c7cd3
remove metrics logging
subotic 3edbbb7
Update webapi/src/main/scala/org/knora/webapi/store/cacheservice/Cach…
subotic c1b0a82
Update webapi/src/main/scala/org/knora/webapi/store/cacheservice/Cach…
subotic a68c389
Update webapi/src/main/scala/org/knora/webapi/store/cacheservice/Cach…
subotic d9e3351
Update docs/architecture/decisions/0002-change-cache-service-manager-…
subotic 51ea313
cleanup
subotic b38d829
Merge branch 'wip/DEV-546-zio-fying-cache-service' of github.com:dasc…
subotic ad9f3ca
bumping dependencies
subotic b04f9c1
cleanup
subotic File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
docs/architecture/decisions |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# C4 Model and ADRs | ||
|
||
## Installation | ||
|
||
```bash | ||
$ brew install adr-tools | ||
``` | ||
|
||
## Usage | ||
|
||
Run the following command from the root directory to start the C4 model browser: | ||
|
||
```bash | ||
$ make structurizer | ||
``` |
19 changes: 19 additions & 0 deletions
19
docs/architecture/decisions/0001-record-architecture-decisions.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# 1. Record architecture decisions | ||
|
||
Date: 2022-03-14 | ||
|
||
## Status | ||
|
||
Accepted | ||
|
||
## Context | ||
|
||
We need to record the architectural decisions made on this project. | ||
|
||
## Decision | ||
|
||
We will use Architecture Decision Records, as [described by Michael Nygard](http://thinkrelevance.com/blog/2011/11/15/documenting-architecture-decisions). | ||
|
||
## Consequences | ||
|
||
See Michael Nygard's article, linked above. For a lightweight ADR toolset, see Nat Pryce's [adr-tools](https://github.com/npryce/adr-tools). |
19 changes: 19 additions & 0 deletions
19
...ecture/decisions/0002-change-cache-service-manager-from-akka-actor-to-zlayer.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# 2. Change Cache Service Manager from Akka-Actor to ZLayer | ||
|
||
Date: 2022-04-06 | ||
|
||
## Status | ||
|
||
Accepted | ||
|
||
## Context | ||
|
||
The `org.knora.webapi.store.cacheservice.CacheServiceManager` was implemented as an `Akka-Actor`. | ||
|
||
## Decision | ||
|
||
As part of the move from `Akka` to `ZIO`, it was decided that the `CacheServiceManager` and the whole implementation of the in-memory and Redis backed cache is refactored using ZIO. | ||
|
||
## Consequences | ||
|
||
The usage from other actors stays the same. The actor messages and responses don't change. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
workspace { | ||
|
||
model { | ||
user = person "User" | ||
softwareSystem = softwareSystem "Software System" | ||
|
||
user -> softwareSystem "Uses" | ||
} | ||
|
||
views { | ||
systemContext softwareSystem "Diagram1" { | ||
include * | ||
autoLayout | ||
} | ||
|
||
theme default | ||
} | ||
|
||
!adrs decisions | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now we going to have a lot of formatting noise