New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(groups): update test data and documentation to use language specific group descriptions (DEV-123) #1921
Merged
irinaschubert
merged 9 commits into
main
from
wip/DEV-123-fix-test-data-and-documentation-groups
Oct 14, 2021
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
55e49fb
Add language to group descriptions
8ca3a99
add language to group descriptions in test data
ce341fb
Update documentation
2977209
Merge branch 'main' into wip/DEV-123-fix-test-data-and-documentation-…
e55631d
Merge branch 'main' into wip/DEV-123-fix-test-data-and-documentation-…
subotic 0dac025
fix failing tests
d73d30d
add plugin to update data
5d67118
update plugin to update data
06f9697
improve code
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,5 +9,6 @@ filegroup( | |
"pr1372.trig", | ||
"pr1615.trig", | ||
"pr1746.trig", | ||
"pr1921.trig", | ||
], | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> . | ||
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> . | ||
@prefix knora-admin: <http://www.knora.org/ontology/knora-admin#> . | ||
|
||
<http://rdfh.ch/projects/0105> a knora-admin:knoraProject ; | ||
knora-admin:projectLongname "Test Project"^^xsd:string ; | ||
knora-admin:projectShortname "test-project"^^xsd:string ; | ||
knora-admin:projectShortcode "0105"^^xsd:string ; | ||
knora-admin:projectDescription "Project description"^^xsd:string ; | ||
knora-admin:projectKeywords "Keyword"^^xsd:string ; | ||
knora-admin:status "true"^^xsd:boolean ; | ||
knora-admin:hasSelfJoinEnabled "false"^^xsd:boolean . | ||
|
||
<http://rdfh.ch/groups/0105/group-without-language-attribute-1> rdf:type knora-admin:UserGroup ; | ||
knora-admin:groupName "Group without language string 1"^^xsd:string ; | ||
knora-admin:groupDescriptions "A group description without language attribute."^^xsd:string ; | ||
knora-admin:belongsToProject <http://rdfh.ch/projects/0105> ; | ||
knora-admin:status "true"^^xsd:boolean ; | ||
knora-admin:hasSelfJoinEnabled "false"^^xsd:boolean . | ||
|
||
<http://rdfh.ch/groups/0105/group-without-language-attribute-2> rdf:type knora-admin:UserGroup ; | ||
knora-admin:groupName "Group without language string 2"^^xsd:string ; | ||
knora-admin:groupDescriptions "A group description without language attribute." ; | ||
knora-admin:belongsToProject <http://rdfh.ch/projects/0105> ; | ||
knora-admin:status "true"^^xsd:boolean ; | ||
knora-admin:hasSelfJoinEnabled "false"^^xsd:boolean . | ||
|
||
<http://rdfh.ch/groups/0105/group-without-language-attribute-3> rdf:type knora-admin:UserGroup ; | ||
knora-admin:groupName "Group without language string 3"^^xsd:string ; | ||
knora-admin:groupDescription "A group description with old predicate name and without language attribute."^^xsd:string ; | ||
knora-admin:belongsToProject <http://rdfh.ch/projects/0105> ; | ||
knora-admin:status "true"^^xsd:boolean ; | ||
knora-admin:hasSelfJoinEnabled "false"^^xsd:boolean . | ||
|
||
<http://rdfh.ch/groups/0105/group-without-language-attribute-4> rdf:type knora-admin:UserGroup ; | ||
knora-admin:groupName "Group without language string 4"^^xsd:string ; | ||
knora-admin:groupDescription "A group description with old predicate name and without language attribute." ; | ||
knora-admin:belongsToProject <http://rdfh.ch/projects/0105> ; | ||
knora-admin:status "true"^^xsd:boolean ; | ||
knora-admin:hasSelfJoinEnabled "false"^^xsd:boolean . | ||
|
||
<http://rdfh.ch/groups/0105/group-with-language-attribute-de> rdf:type knora-admin:UserGroup ; | ||
knora-admin:groupName "Group with language string"^^xsd:string ; | ||
knora-admin:groupDescriptions "Eine Gruppe mit Sprachattribut."@de ; | ||
knora-admin:belongsToProject <http://rdfh.ch/projects/0105> ; | ||
knora-admin:status "true"^^xsd:boolean ; | ||
knora-admin:hasSelfJoinEnabled "false"^^xsd:boolean . | ||
|
||
<http://rdfh.ch/groups/0105/group-with-language-attribute-en> rdf:type knora-admin:UserGroup ; | ||
knora-admin:groupName "Group with language string"^^xsd:string ; | ||
knora-admin:groupDescriptions "A group with language attribute."@en ; | ||
knora-admin:belongsToProject <http://rdfh.ch/projects/0105> ; | ||
knora-admin:status "true"^^xsd:boolean ; | ||
knora-admin:hasSelfJoinEnabled "false"^^xsd:boolean . | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment: In fact this is a breaking change. But groups endpoint is not used yet (at least in dsp-app) but already implemented in js-lib.