New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(projects): refactor projects route with value objects (DEV-64) #1909
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
367980b
add value objects for projects
8520336
WIP
3b3f32b
fix(routing): optiona IRI validation
mpro7 a0d5f97
refactor: remov redundant traits + make sealed abstract classes private
mpro7 1dff6e9
Merge branch 'main' into wip/DSP-1555-refactor-projects-route
mpro7 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
...in/scala/org/knora/webapi/messages/admin/responder/usersmessages/ProjectPayloadsADM.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
package org.knora.webapi.messages.admin.responder.usersmessages | ||
|
||
import org.knora.webapi.IRI | ||
|
||
/** | ||
* Project payload | ||
*/ | ||
sealed abstract case class ProjectCreatePayloadADM private ( | ||
id: Option[IRI], | ||
shortname: Shortname, | ||
shortcode: Shortcode, | ||
longname: Option[Longname], | ||
description: Description, | ||
keywords: Keywords, | ||
logo: Option[Logo], | ||
status: Status, | ||
selfjoin: Selfjoin | ||
) | ||
|
||
object ProjectCreatePayloadADM { | ||
|
||
/** The create constructor */ | ||
def create( | ||
id: Option[IRI] = None, | ||
shortname: Shortname, | ||
shortcode: Shortcode, | ||
longname: Option[Longname] = None, | ||
description: Description, | ||
keywords: Keywords, | ||
logo: Option[Logo] = None, | ||
status: Status, | ||
selfjoin: Selfjoin | ||
): ProjectCreatePayloadADM = | ||
new ProjectCreatePayloadADM( | ||
id = id, | ||
shortname = shortname, | ||
shortcode = shortcode, | ||
longname = longname, | ||
description = description, | ||
keywords = keywords, | ||
logo = logo, | ||
status = status, | ||
selfjoin = selfjoin | ||
) {} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
146 changes: 0 additions & 146 deletions
146
...src/main/scala/org/knora/webapi/messages/admin/responder/usersmessages/ValueObjects.scala
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strictly speaking this does not need a smart constructor, since it doesn't do any "smart" checks on it and could be written as a
final case class ProjectCreatePayloadADM(...)
. We can leave it like it is and if no smart checks get added over time, then we can refactor it.