New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add an RDF processing façade (2nd iteration) (DSP-1083) #1759
Conversation
- Move SparqlSelectResponse to RDF API, rename to SparqlSelectResult.
# Conflicts: # webapi/src/main/scala/org/knora/webapi/responders/admin/ListsResponderADM.scala
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you for implementing this.
} | ||
} | ||
|
||
// Wrap that Map in an ErrorHandlingMap that will gracefully report errors about missing values when they |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gracefully :-D
@@ -906,7 +907,7 @@ class SearchResponderV2(responderData: ResponderData) extends ResponderWithStand | |||
} | |||
|
|||
prequeryResponseNotMerged.copy( | |||
results = SparqlSelectResponseBody(prequeryRowsMerged) | |||
results = SparqlSelectResultBody(prequeryRowsMerged) | |||
) | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha, I found something. Please add an empty line here :-D
Thanks for the review! I will try harder to make more mistakes next time. :) |
resolves DSP-1083
RdfFormatUtil
, and use it in:HttpTriplestoreConnector.turtleToTrig
ProjectsResponderADM.projectDataGetRequestADM
RepositoryUpdater
RdfRepository
for using SPARQL to query anRdfModel
in a test.SparqlSelectResponse
fromTriplestoreMessages
intoorg.knora.webapi.messages.util.rdf
, and rename itSparqlSelectResult
, so it can be used withRdfRepository
.InconsistentTriplestoreDataException
->InconsistentRepositoryDataException
so it can be used withRdfRepository
.TEIHeader
to use the RDF façade.rdf:Description
elements, to facilitate writing XSLT stylesheets. (Previously, you could get a mix ofrdf:Description
elements and typed elements, making it difficult to write XPath.)test_data/test_route/texts/beol/header.xsl
(used byKnoraSipiIntegrationV1ITSpec
), so it works with RDF/XML in that format.For the next PR: