New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gravsearch): Allow comparing variables representing resource IRIs #1713
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
25da03a
feat(gravsearch): Allow comparing variables representing resource IRIs
add186d
fix(InferringGravsearchTypeInspector): Optimise away statements becau…
e288e06
Merge branch 'develop' into wip/DSP-656-gravsearch
69bdd61
feat(gravsearch): Infer type of resource IRI in FILTER.
f675fbc
docs(gravsearch): Document resource comparisons.
db9b92c
test(gravsearch): Add test.
99d13d1
test(gravsearch): Remove subject from test letter.
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| { | ||
| "@id" : "http://rdfh.ch/0801/_B3lQa6tSymIq7_7SowBsA", | ||
| "@type" : "beol:letter", | ||
| "beol:hasAuthorValue" : { | ||
| "@id" : "http://rdfh.ch/0801/_B3lQa6tSymIq7_7SowBsA/values/Cvp07eTqQQSnYdcvqlWW_g", | ||
| "@type" : "knora-api:LinkValue", | ||
| "knora-api:arkUrl" : { | ||
| "@type" : "xsd:anyURI", | ||
| "@value" : "http://0.0.0.0:3336/ark:/72163/1/0801/_B3lQa6tSymIq7_7SowBsAD/Cvp07eTqQQSnYdcvqlWW_gI" | ||
| }, | ||
| "knora-api:attachedToUser" : { | ||
| "@id" : "http://rdfh.ch/users/PSGbemdjZi4kQ6GHJVkLGF" | ||
| }, | ||
| "knora-api:hasPermissions" : "CR knora-admin:Creator|M knora-admin:ProjectMember|V knora-admin:KnownUser|RV knora-admin:UnknownUser", | ||
| "knora-api:linkValueHasTarget" : { | ||
| "@id" : "http://rdfh.ch/0801/VvYVIy-FSbOJBsh2d9ZFJw", | ||
| "@type" : "beol:person", | ||
| "knora-api:arkUrl" : { | ||
| "@type" : "xsd:anyURI", | ||
| "@value" : "http://0.0.0.0:3336/ark:/72163/1/0801/VvYVIy=FSbOJBsh2d9ZFJwi" | ||
| }, | ||
| "knora-api:attachedToProject" : { | ||
| "@id" : "http://rdfh.ch/projects/yTerZGyxjZVqFMNNKXCDPF" | ||
| }, | ||
| "knora-api:attachedToUser" : { | ||
| "@id" : "http://rdfh.ch/users/PSGbemdjZi4kQ6GHJVkLGF" | ||
| }, | ||
| "knora-api:creationDate" : { | ||
| "@type" : "xsd:dateTimeStamp", | ||
| "@value" : "2018-06-04T08:56:22.513Z" | ||
| }, | ||
| "knora-api:hasPermissions" : "CR knora-admin:Creator|M knora-admin:ProjectMember|V knora-admin:KnownUser|RV knora-admin:UnknownUser", | ||
| "knora-api:userHasPermission" : "RV", | ||
| "knora-api:versionArkUrl" : { | ||
| "@type" : "xsd:anyURI", | ||
| "@value" : "http://0.0.0.0:3336/ark:/72163/1/0801/VvYVIy=FSbOJBsh2d9ZFJwi.20180604T085622513Z" | ||
| }, | ||
| "rdfs:label" : "Testperson2" | ||
| }, | ||
| "knora-api:userHasPermission" : "RV", | ||
| "knora-api:valueCreationDate" : { | ||
| "@type" : "xsd:dateTimeStamp", | ||
| "@value" : "2018-06-04T08:56:33.879Z" | ||
| }, | ||
| "knora-api:valueHasUUID" : "Cvp07eTqQQSnYdcvqlWW_g", | ||
| "knora-api:versionArkUrl" : { | ||
| "@type" : "xsd:anyURI", | ||
| "@value" : "http://0.0.0.0:3336/ark:/72163/1/0801/_B3lQa6tSymIq7_7SowBsAD/Cvp07eTqQQSnYdcvqlWW_gI.20180604T085633879Z" | ||
| } | ||
| }, | ||
| "beol:hasRecipientValue" : { | ||
| "@id" : "http://rdfh.ch/0801/_B3lQa6tSymIq7_7SowBsA/values/DVqPKuBBSIauVqjUC7bNvA", | ||
| "@type" : "knora-api:LinkValue", | ||
| "knora-api:arkUrl" : { | ||
| "@type" : "xsd:anyURI", | ||
| "@value" : "http://0.0.0.0:3336/ark:/72163/1/0801/_B3lQa6tSymIq7_7SowBsAD/DVqPKuBBSIauVqjUC7bNvAe" | ||
| }, | ||
| "knora-api:attachedToUser" : { | ||
| "@id" : "http://rdfh.ch/users/PSGbemdjZi4kQ6GHJVkLGF" | ||
| }, | ||
| "knora-api:hasPermissions" : "CR knora-admin:Creator|M knora-admin:ProjectMember|V knora-admin:KnownUser|RV knora-admin:UnknownUser", | ||
| "knora-api:linkValueHasTarget" : { | ||
| "@id" : "http://rdfh.ch/0801/H7s3FmuWTkaCXa54eFANOA", | ||
| "@type" : "beol:person", | ||
| "knora-api:arkUrl" : { | ||
| "@type" : "xsd:anyURI", | ||
| "@value" : "http://0.0.0.0:3336/ark:/72163/1/0801/H7s3FmuWTkaCXa54eFANOAd" | ||
| }, | ||
| "knora-api:attachedToProject" : { | ||
| "@id" : "http://rdfh.ch/projects/yTerZGyxjZVqFMNNKXCDPF" | ||
| }, | ||
| "knora-api:attachedToUser" : { | ||
| "@id" : "http://rdfh.ch/users/PSGbemdjZi4kQ6GHJVkLGF" | ||
| }, | ||
| "knora-api:creationDate" : { | ||
| "@type" : "xsd:dateTimeStamp", | ||
| "@value" : "2018-06-04T08:55:34.086Z" | ||
| }, | ||
| "knora-api:hasPermissions" : "CR knora-admin:Creator|M knora-admin:ProjectMember|V knora-admin:KnownUser|RV knora-admin:UnknownUser", | ||
| "knora-api:userHasPermission" : "RV", | ||
| "knora-api:versionArkUrl" : { | ||
| "@type" : "xsd:anyURI", | ||
| "@value" : "http://0.0.0.0:3336/ark:/72163/1/0801/H7s3FmuWTkaCXa54eFANOAd.20180604T085534086Z" | ||
| }, | ||
| "rdfs:label" : "Testperson1" | ||
| }, | ||
| "knora-api:userHasPermission" : "RV", | ||
| "knora-api:valueCreationDate" : { | ||
| "@type" : "xsd:dateTimeStamp", | ||
| "@value" : "2018-06-04T08:56:33.879Z" | ||
| }, | ||
| "knora-api:valueHasUUID" : "DVqPKuBBSIauVqjUC7bNvA", | ||
| "knora-api:versionArkUrl" : { | ||
| "@type" : "xsd:anyURI", | ||
| "@value" : "http://0.0.0.0:3336/ark:/72163/1/0801/_B3lQa6tSymIq7_7SowBsAD/DVqPKuBBSIauVqjUC7bNvAe.20180604T085633879Z" | ||
| } | ||
| }, | ||
| "knora-api:arkUrl" : { | ||
| "@type" : "xsd:anyURI", | ||
| "@value" : "http://0.0.0.0:3336/ark:/72163/1/0801/_B3lQa6tSymIq7_7SowBsAD" | ||
| }, | ||
| "knora-api:attachedToProject" : { | ||
| "@id" : "http://rdfh.ch/projects/yTerZGyxjZVqFMNNKXCDPF" | ||
| }, | ||
| "knora-api:attachedToUser" : { | ||
| "@id" : "http://rdfh.ch/users/PSGbemdjZi4kQ6GHJVkLGF" | ||
| }, | ||
| "knora-api:creationDate" : { | ||
| "@type" : "xsd:dateTimeStamp", | ||
| "@value" : "2018-06-04T08:56:33.879Z" | ||
| }, | ||
| "knora-api:hasPermissions" : "CR knora-admin:Creator|M knora-admin:ProjectMember|V knora-admin:KnownUser|RV knora-admin:UnknownUser", | ||
| "knora-api:userHasPermission" : "RV", | ||
| "knora-api:versionArkUrl" : { | ||
| "@type" : "xsd:anyURI", | ||
| "@value" : "http://0.0.0.0:3336/ark:/72163/1/0801/_B3lQa6tSymIq7_7SowBsAD.20180604T085633879Z" | ||
| }, | ||
| "rdfs:label" : "Testbrief1", | ||
| "@context" : { | ||
| "rdf" : "http://www.w3.org/1999/02/22-rdf-syntax-ns#", | ||
| "knora-api" : "http://api.knora.org/ontology/knora-api/v2#", | ||
| "rdfs" : "http://www.w3.org/2000/01/rdf-schema#", | ||
| "beol" : "http://0.0.0.0:3333/ontology/0801/beol/v2#", | ||
| "xsd" : "http://www.w3.org/2001/XMLSchema#" | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the statement with a 'hasSubject' because if not this test letter will appear in the visualizations of the BEOL subject index and their respective letters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is test data. Why would it be used on the BEOL live server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beol-data.ttl is not a pure test data. It contains subject index definition as list nodes, etc. The imported BEOL data and the data in this file are combined and made available on production server. for example, you can see that test letter defined in this file has ended up on Beol production server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand, but that doesn't seem right to me, because there are already fake letters in
beol-data.ttl. Wouldn't it be better to make two files, to separate the real data from the test data?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the
hasSubjectin 99d13d1.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would have been, but never happened!