Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sipi): Improve performance of file value query #1697

Merged
merged 5 commits into from Sep 2, 2020
Merged

fix(sipi): Improve performance of file value query #1697

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0f864d6
fix(sipi): Optimise file value query.
Sep 1, 2020
ad77987
style(sparql): Fix comment.
Sep 1, 2020
4a5041c
Merge branch 'develop' into wip/DSP-582-file-value
Sep 2, 2020
05029e9
enhancement(sparql): Don't bother filtering out permissions and proje…
Sep 2, 2020
12f433e
enhancement(sparql): Add a useless FILTER because it makes the query …
Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...twirl/org/knora/webapi/messages/twirl/queries/sparql/admin/getFileValueStandard.scala.txt
View file
Open in desktop
Expand Up @@ -50,6 +50,10 @@ CONSTRUCT {
knora-base:attachedToProject ?resourceProject .

?fileValue ?objPred ?objObj .

@* This FILTER is unnecessary, but it makes Jena run the query faster. *@
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that comment means that we know how the triplestore works ;-)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly! :)

FILTER(?objPred != knora-base:previousValue)

?currentFileValue knora-base:isDeleted false .
?resource knora-base:isDeleted false .
}