Wip/dsp 168 refactor gravsearch (#1658)

dasch-swiss · Jun 23, 2020 · fdc5140 · fdc5140
1 parent ff87b7a
commit fdc5140
Show file tree

Hide file tree

Showing 3 changed files with 213 additions and 139 deletions.
diff --git a/webapi/src/main/scala/org/knora/webapi/responders/v2/search/MainQueryResultProcessor.scala b/webapi/src/main/scala/org/knora/webapi/responders/v2/search/MainQueryResultProcessor.scala
@@ -41,6 +41,7 @@ object MainQueryResultProcessor {
      * @param typeInspectionResult                    results of type inspection of the input query.
      * @return results with only the values the user asked for in the input query's CONSTRUCT clause.
      */
+    // TODO apparently not needed, work is taken care in ConstructResponseUtilV2.nestResources
     def getRequestedValuesFromResultsWithFullGraphPattern(queryResultsWithFullGraphPattern: RdfResources,
                                                           valueObjectVarsAndIrisPerMainResource: ValueObjectVariablesAndValueObjectIris,
                                                           allResourceVariablesFromTypeInspection: Set[QueryVariable],

diff --git a/...v2/search/gravsearch/prequery/NonTriplestoreSpecificGravsearchToPrequeryTransformer.scala b/...v2/search/gravsearch/prequery/NonTriplestoreSpecificGravsearchToPrequeryTransformer.scala
@@ -273,11 +273,13 @@ class NonTriplestoreSpecificGravsearchToPrequeryTransformer(constructClause: Con
     /**
      * The variable names used in the GROUP_CONCAT expressions for dependent resources.
      */
+    // TODO only used by GravsearchMainQueryGenerator and not clear why
     val dependentResourceVariablesGroupConcat: Set[QueryVariable] = dependentResourceGroupConcat.map(_.outputVariable)
 
     /**
      * The variable names used in the GROUP_CONCAT expressions for values.
      */
+    // TODO same as above
     val valueObjectVariablesGroupConcat: Set[QueryVariable] = valueGroupConcatVariablesPerResource.values.flatten.toSet
 
     /**