Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide better defaults for mimetype to extension mapping #81

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

provide better defaults for mimetype to extension mapping #81

wants to merge 31 commits into from

Commits on Jan 5, 2023

  1. initial code from pr !15

    @mx1up
    mx1up committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    86114bd View commit details
    Browse the repository at this point in the history

  2. update copyright year

    @mx1up
    mx1up committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    9f1ef55 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. improve lookup: case-insensitive and use firstWhereOrNull instead of … 

    …for loop
    @mx1up
    mx1up committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    c9e3e15 View commit details
    Browse the repository at this point in the history

  2. tests cleanup

    @mx1up
    mx1up committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    0f37a4b View commit details
    Browse the repository at this point in the history

  3. check baseline

    @mx1up
    mx1up committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    f4c4a4f View commit details
    Browse the repository at this point in the history

  4. test to check whether each mimetype with multiple extensions has a pr… 

    …eferred extension defined
    @mx1up
    mx1up committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    a9ec842 View commit details
    Browse the repository at this point in the history

  5. reformat

    @mx1up
    mx1up committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    02b9dcb View commit details
    Browse the repository at this point in the history

  6. apparently, the function already existed :roll-eyes: but the preferre… 

    …d extension not. for backwards compatibility: add `extensionFromMimeOrNull`, and add an `orElse` param for `extensionFromMime` as the standard behavior results in creating an invalid filename.
    @mx1up
    mx1up committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    1ad29e9 View commit details
    Browse the repository at this point in the history

  7. probably better not to enforce a preferred extension for mime types w… 

    …ith multiple extensions. There are quite some, but most of them are legacy, and new mimetypes tend to map to 1 extension (no 3 chars limit anymore), so less useful in the future
    @mx1up
    mx1up committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    84a8f43 View commit details
    Browse the repository at this point in the history

  8. added some preferred extensions for common file formats

    @mx1up
    mx1up committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    1f2ab54 View commit details
    Browse the repository at this point in the history

  9. cleanup old tests

    @mx1up
    mx1up committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    fbf8f68 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. test orElse param for unknown mime type

    @mx1up
    mx1up committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    6600a3f View commit details
    Browse the repository at this point in the history

  2. link to file

    @mx1up
    mx1up committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    6fe7ecb View commit details
    Browse the repository at this point in the history

  3. fix title to be more accurate

    @mx1up
    mx1up committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    d57b9fc View commit details
    Browse the repository at this point in the history

  4. rename to existing function

    @mx1up
    mx1up committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    0d6c519 View commit details
    Browse the repository at this point in the history

  5. add standard behavior to make example more clear

    @mx1up
    mx1up committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    bb9fc15 View commit details
    Browse the repository at this point in the history

  6. include text/plain mapping again

    @mx1up
    mx1up committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    7280615 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. remove collection dependency

    @mx1up
    mx1up committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    40107ff View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. lookupExtension has been renamed to existing extensionFromMime

    @mx1up
    mx1up committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    c384ef3 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Merge branch 'dart-lang:master' into issue13_contenttype_to_ext

    @mx1up
    mx1up committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    9ca2e5b View commit details
    Browse the repository at this point in the history

  2. drop non-nullable extensionFromMime variant per review suggestion

    @mx1up
    mx1up committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    76f80f6 View commit details
    Browse the repository at this point in the history

  3. doc update: try using noun phrase; don't refer to implementation details

    @mx1up
    mx1up committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    7b2804f View commit details
    Browse the repository at this point in the history

  4. don't use extension method

    @mx1up
    mx1up committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    65c7016 View commit details
    Browse the repository at this point in the history

  5. remove addMimeType and leave it for another time..

    @mx1up
    mx1up committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    e8a6ed5 View commit details
    Browse the repository at this point in the history

  6. remove addMimeType documentation

    @mx1up
    mx1up committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    f8642bd View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. be more specific about extension

    @mx1up
    mx1up committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    8acfbe4 View commit details
    Browse the repository at this point in the history

  2. review feedback: avoid abbreviations, just overwrite function param

    @mx1up
    mx1up committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f20c40f View commit details
    Browse the repository at this point in the history

  3. since extensions can no longer by added at runtime, we can optimize a… 

    …nd avoid the linear search
    @mx1up
    mx1up committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    2be331f View commit details
    Browse the repository at this point in the history

  4. local var no longer needed

    @mx1up
    mx1up committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    60e9a7b View commit details
    Browse the repository at this point in the history

  5. update docs

    @mx1up
    mx1up committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    54da123 View commit details
    Browse the repository at this point in the history

  6. update docs

    @mx1up
    mx1up committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    d190914 View commit details
    Browse the repository at this point in the history