Enforce sandbox isolation to prevent information leaks #2943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://github.com/dart-lang/dart-pad/wiki/Embedding-Guide websites can embed dart pad however its currently possible to leak data contained in a sites embed since the sandbox is not isolated.
I'm new to this code base so please tell me if this is WAI or my fix is flawed.
In #2044 looks like it was decided not to allow for sandbox escapes of this kind.