Create version which allows Dart 3.0 SDKs. #283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
mit-mit
reviewed
May 3, 2023
| description: Collections and utilities functions and classes related to collections. | ||
| repository: https://github.com/dart-lang/collection | ||
|
|
||
| environment: | ||
| sdk: ">=2.18.0 <3.0.0" | ||
| sdk: ">=2.18.0 <4.0.0" |
There was a problem hiding this comment.
This really makes no difference, as we re-write the upper constraint to 4.0.0 anyway for null safe packages.
But don't we want to change the lower constraint too as you are about to start using Dart 3 modifiers?
There was a problem hiding this comment.
I prefer to not depend on constraint re-writing. It's a hack. It's fine transitionally, but I'd like to have a version which opts in to <4.0.0.
But I already had a PR for that, so closing this one.
|
Whoops, I already had a CL for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version just allows Dart 3.0 SDKs, a second CL will switch the package to being 3.0 code.
@mit-mit