Changes to Equality classes. #265
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`MapEquality` and `SetEquality` now expects the provided equalities to be compatible with the inherent equals (and hash) of the map or set. That allows using `Map.operator[]` and `Set.lookup` to match entries/elements from one collection with those of the other, instead of building an extra hash-map on the side to count occurrences. This helps `DeepCollectionEquality` which is likely to traverse a larger collection structure (mainly maps) and do repeated equals/hash code on sup-components. For unordered `DeepCollectionEquality`, a cache of computed values is added to avoid repeating the same computation during the traversal of a map-structure. Also adds `JsonEquality` which is tuned to JSON-like map/list/basic-value structures, and which assumes everything uses default `==` equality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROOF-OF-CONCEPT. DO NOT LAND.
MapEqualityandSetEqualitynow expects the provided equalities to be compatible with the inherent equals (and hash) of the map or set.That allows using
Map.operator[]andSet.lookupto match entries/elements from one collection with those of the other, instead of building an extrahash-map on the side to count occurrences.
This helps
DeepCollectionEqualitywhich is likely to traverse a larger collection structure (mainly maps) and do repeated equals/hash code on sup-components.For unordered
DeepCollectionEquality, a cache of computed values is added to avoid repeating the same computation during the traversal of a map-structure.Smaller changes to other classes:
DefaultEqualityandIdentityEqualitynow have only factory constructors, so cannot be extended. There should be no need for that.Also adds
JsonEqualitywhich is tuned to JSON-like map/list/basic-value structures, and which assumes everything uses default==equality.NOTICE: This is probably a breaking change, so the version number should be major-version-incremented.
I believe this package is pinned by Flutter, so that'll be fun. 馃槈