Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tools to update and generate tables and tests. #72

Merged
merged 5 commits into from
Apr 19, 2023
Merged

Add tools to update and generate tables and tests. #72

merged 5 commits into from
Apr 19, 2023

Conversation

lrhn
Copy link
Member

@lrhn lrhn commented Jan 26, 2023

Include low-level benchmark in tool/.

@lrhn lrhn requested a review from natebosch January 26, 2023 16:22
Copy link
Member

@natebosch natebosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a lot here, and since this is tooling code I didn't review as fully as I would if it was user facing. This looks pretty good overall.

tool/benchmark.dart Outdated Show resolved Hide resolved
tool/bin/gentable.dart Outdated Show resolved Hide resolved
tool/bin/gentable.dart Outdated Show resolved Hide resolved
tool/bin/gentest.dart Show resolved Hide resolved
tool/src/args.dart Outdated Show resolved Hide resolved
tool/src/atsp.dart Outdated Show resolved Hide resolved
tool/src/atsp.dart Outdated Show resolved Hide resolved
tool/src/grapheme_category_loader.dart Show resolved Hide resolved
tool/src/shared.dart Outdated Show resolved Hide resolved
lrhn and others added 3 commits April 18, 2023 13:44
Include low-level benchmark in tool/.
Co-authored-by: Nate Bosch <nbosch@google.com>
(Didn't change double-quoted strings. Not worth it.)
@lrhn
Copy link
Member Author

lrhn commented Apr 18, 2023

Addressed comments, switched to more lints.

Didn't generate new files for now, since data files haven't changed.

Needs to be above 2.17 to allow using team-lints.
@lrhn lrhn merged commit b306414 into master Apr 19, 2023
8 checks passed
@lrhn lrhn deleted the tools branch April 19, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants