Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isort version in .pre-commit-config.yaml that became incompatible rencently #365

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RamonGiovane
Copy link

Updating pre-commit 's isort.

The current version raises this error when make prep:

          RuntimeError: The Poetry configuration is invalid:
            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

Solution is to update to version 5.12.0
Related SO post: https://stackoverflow.com/a/75269701/8843585

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 84.93% // Head: 84.93% // No change to project coverage 👍

Coverage data is based on head (ef53acb) compared to base (1c54620).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #365   +/-   ##
=======================================
  Coverage   84.93%   84.93%           
=======================================
  Files          21       21           
  Lines        1845     1845           
  Branches      284      284           
=======================================
  Hits         1567     1567           
  Misses        236      236           
  Partials       42       42           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RamonGiovane RamonGiovane changed the title Fix .pre-commit-config.yaml isort version that broke rencently Fix isort version in .pre-commit-config.yaml that became incompatible rencently Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant