Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When running in GitHub Actions, force colors on #345

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AndydeCleyre
Copy link
Contributor

Fixes #243

Maybe the coloring can be improved from here, this is at least what I see, with this change:

image

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 84.94% // Head: 84.94% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (1f4a041) compared to base (518a0ec).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   84.94%   84.94%           
=======================================
  Files          21       21           
  Lines        1846     1847    +1     
  Branches      284      284           
=======================================
+ Hits         1568     1569    +1     
  Misses        236      236           
  Partials       42       42           
Impacted Files Coverage Δ
ward/_terminal.py 63.02% <100.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AndydeCleyre
Copy link
Contributor Author

I'm having second thoughts about this, as I'm now seeing some tools checking for the environment parameter FORCE_COLOR (set to, e.g. 1). So it should probably be enough to check for FORCE_COLOR here, and let Action authors set that in the action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colour output when running on CI platforms that support it
2 participants