Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dynamic theme fix for porkbun.com #12686

Closed
wants to merge 2 commits into from

Conversation

oberrich
Copy link
Contributor

@oberrich oberrich commented May 6, 2024

Properly invert sales chat pop-up

https://i.imgur.com/8O0n7CO.png
(before)

https://i.imgur.com/UlAktw3.png
(after)

Properly invert sales chat pop-up
@oberrich oberrich marked this pull request as draft May 6, 2024 02:37
@oberrich
Copy link
Contributor Author

oberrich commented May 6, 2024

I see there is a slight problem: The chat pop-up gets loaded in delayed. Is there some way to config dark-reader to be run again on DOM change or something?

@alexanderby
Copy link
Member

What browser are you using? I don't see such white corners.

@oberrich
Copy link
Contributor Author

oberrich commented May 6, 2024

What browser are you using? I don't see such white corners.

Version 123.0.6312.113 (Official Build, ungoogled-chromium) (64-bit) and I have a fast connection through fiber optic cable.
Opening the site sometimes results in the image being white, if I disable and reenable it for porkbun after loading the site, it correctly inverts the image.

The chat widget is loaded through an iframe - possibly at a later point, maybe that causes the issue? Is there some control to tell darkreader to watch for DOM changes on a certain element / "subtree" and does that work for iframes?

I noticed there's also an issue with imgur embeds not being inverted on some websites, maybe thats an embedding issue in general.

@alexanderby
Copy link
Member

Ah, I see the issue in version 4.9.84. But it works fine in the latest build. I will check once again before the next release.

@oberrich oberrich closed this May 15, 2024
@oberrich oberrich reopened this May 15, 2024
@oberrich
Copy link
Contributor Author

Landed in 46af1fd

@oberrich oberrich closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants