New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for specific site #12667
base: main
Are you sure you want to change the base?
Update for specific site #12667
Conversation
SVG icons were turning dark instead of remaining white, for better visibility As seen here: https://i.imgur.com/XXpYDtm.png Expected result: https://i.imgur.com/NZsYGe9.png
Hi @L11K, did it look fine before? Or did you notice the problem recently? |
If you look at these SVG icons in Chrome (or FireFox) Dev Tools, do you see |
Hi,@alexanderby, It always looked like this, but I was too lazy to "fix" it before yesterday. Now I want my coworkers to use the extension too, which having to apply the "fix" to them one-by-one, as they aren't as techno-able. |
I meant the |
Ah, yes, after data-icon. Thankfully even tho I didn't see, I posted the screenshot. Thanks for your time and patience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not starting tests until commit will be fixed.
Adjusting for consistency
@alexanderby after reading your comments I think I will leave it to you if it should be merged or not. |
SVG icons were turning dark instead of remaining white, for better visibility, for both light and dark themes.
As seen here: