support trick_doubleTapLockScreen and trick_doubleTapStatusBar on android 10 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… trick_quickPulldown As I wanted to add support trick_doubleTapLockScreen and trick_doubleTapStatusBar on android 10 I added this framework to abstract the code: class FeatureFactory ==================== - create instances of features if available on a given android platform interface Feature ================= - A feature is the implementation of an modification you want to do with Xposed. - the same feature could be implemented for a different android sdk in another file
…tingsActivity Done for: - trick_double_tap_lockscreen - trick_double_tap_statusbar - trick_quick_pulldown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add support for
trick_doubleTapLockScreenandtrick_doubleTapStatusBarto android 10.I added some helper classes to abstract the code and ease the development for new features.
class FeatureFactory
interface Feature
So the original code for
trick_doubleTapStatusBarandtrick_doubleTapLockScreenfor SDK >= 31 was moved to:
com/darkeyes/tricks/features/DoubleTapStatusBarOrLockScreenSdk31AndHigher.javaAnd
trick_quick_pulldownis now in:com/darkeyes/tricks/features/QuickPullDownFeatureSdk31AndHigher.javatrick_doubleTapStatusBarandtrick_doubleTapLockScreenfor Android 10 is here:com/darkeyes/tricks/features/DoubleTapStatusBarOrLockScreenSdk29.javaThe code is only tested on Android 10. I've no idea if I messed something up.
Please let me know. Thanks