Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: unify version numbers #386

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

*: unify version numbers #386

wants to merge 2 commits into from

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Jun 9, 2020

Move away from semantic versioning, and simplify release process.

The rationale is that we get very little benefit by using SemVer, because backwards compatibility isn't really applicable to us: there is no state, and users just want to be on the latest. It could be argued we don't need versions, and could just use a commit hash instead. I think versions help by making it clear how far behind one is to latest.

NOTE: Only seth cause it's a draft, but the same would apply for other tools.

The version number patching happening in Nix means this doesn't support make-based builds, /cc @rainbreak.

@asymmetric asymmetric requested a review from MrChico June 9, 2020 15:07
@@ -18,6 +18,10 @@ stdenv.mkDerivation rec {
else ""}
'';

postFixup = ''
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be postInstall and the current postInstall should be postFixup.

@asymmetric asymmetric force-pushed the unify-readme branch 2 times, most recently from 8bec962 to 5b8b1b6 Compare June 9, 2020 15:21
@dapphub dapphub deleted a comment Jul 17, 2020
@rainbreak
Copy link
Member

Would be nice if the --version output both the version number and the commit hash. This would help with 1) easy checkout and 2) disambiguation if I build locally from an unbumped development version.

@asymmetric
Copy link
Contributor Author

asymmetric commented Jul 17, 2020

Sidenote: I think --version should actually be version, since it's not a flag to another command but a command in itself, IMO.

Unless one sees it as a flag to seth. But I don't see it that way ;)

But this should probably be a larger discussion, since it applies to many other commands (namely, the conversion ones).

@rainbreak
Copy link
Member

I think --version is more expected from other cli tools, so it should at least alias to version (e.g. git allows both). Also we have seth --to-wei etc. as commands rather than flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants