Extend Lock & Swap Lock #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HouseOfHufflepuff
commented
May 12, 2023
•
HouseOfHufflepuff
commented
- Added function to extend the lock of an NFT. This will be used when we mint sticker book tokens.
- Added tx and tests to swap a lock. This will be used to upgrade elements of the sticker book.
- Removed duration from data structure as it can be derived.
HouseOfHufflepuff
requested review from
judezhu,
rrrkren,
Deewai and
javiersoto15
javiersoto15
previously approved these changes
May 15, 2023
rrrkren
reviewed
May 15, 2023
satyamakgec
reviewed
May 17, 2023
| @@ -83,6 +94,14 @@ pub contract NFTLocker { | |||
| return false | |||
| } | |||
|
|
|||
| pub fun nftIsLocked(id: UInt64, nftType: Type): Bool { | |||
| if let lockedToken = (NFTLocker.lockedTokens[nftType]!)[id] { | |||
| return true | |||
There was a problem hiding this comment.
Don't you need to check the lockedUntil here?
There was a problem hiding this comment.
Glad you asked, because my intention was to delete the token from NFTLocker.lockedTokens, so that the key does not exist & would not have a lockedUntil. But I found a bug that I fixed here.
nftIsLocked will return false when the token does not exist for the type. Added tests to support.
EricLin-wk
reviewed
Nov 3, 2023
| NFTLocker.nftIsLocked( | ||
| id: id, | ||
| nftType: nftType | ||
| ) == true : "token is not locked" |
There was a problem hiding this comment.
I think there could be another validation for old lockedUntil + extendedDuration > now otherwise the extension seems moot
Deewai
reviewed
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.