Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15779 control: Explicitly link to libgurt in cgo #14388

Merged
merged 1 commit into from
May 17, 2024

Conversation

kjacque
Copy link
Contributor

@kjacque kjacque commented May 16, 2024

Lack of it was causing failures in the Ubuntu build.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Lack of it was causing failures in the Ubuntu build.

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
@kjacque kjacque self-assigned this May 16, 2024
@kjacque kjacque requested review from a team as code owners May 16, 2024 14:22
@kjacque
Copy link
Contributor Author

kjacque commented May 16, 2024

No need for a test-tag -- this was a build issue.

Copy link

Ticket title is 'Build DAOS (ubuntu docker) is failing'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-15779

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14388/1/execution/node/1454/log

@kjacque
Copy link
Contributor Author

kjacque commented May 17, 2024

Test failure is a timeout in the daos_test extend_simple test. There are a number of existing tickets involving this test and timeouts. This PR does not seem related.

@kjacque kjacque added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label May 17, 2024
@kjacque kjacque requested a review from a team May 17, 2024 19:58
@daltonbohning daltonbohning merged commit 2d8ff91 into master May 17, 2024
54 of 56 checks passed
@daltonbohning daltonbohning deleted the kjacque/fix-ubuntu-docker-build branch May 17, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
4 participants