Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15851 ci: Follow CI_PR_REPOS if provided by Jenkins #14387

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

DAOS-15851 ci: Follow CI_PR_REPOS if provided by Jenkins #14387

wants to merge 4 commits into from
+5 −0

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented May 16, 2024 •
edited

Required for: daos-stack/go-build-toolchain@c8fde3e

Example build results:
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14387/7/parameters/

https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14387/7/pipeline-console/log?nodeId=189

...
[2024-05-20T19:29:27.522Z] PR_REPOS="go-build-toolchain@PR-25:9"                                  \
...
[2024-05-20T19:41:30.450Z] DEBUG util.py:448:  go-build-toolchain:PR-25:9                      554 kB/s |  58 kB     00:00    
...

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/DAOS-15851

@grom72 grom72 force-pushed the grom72/use-CI_PR_REPOS branch 2 times, most recently from d05ce79 to 62222e4 Compare May 16, 2024 19:33
@grom72
DAOS-15851 ci: Follow CI_PR_REPOS if provided by Jenkins
e0933d0 
Required-githooks: true

Signed-off-by: Gromadzki, Tomasz <tomasz.gromadzki@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14387/6/execution/node/340/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14387/6/execution/node/339/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14387/6/execution/node/368/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14387/6/execution/node/352/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14387/7/execution/node/343/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14387/7/execution/node/349/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14387/7/execution/node/371/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14387/7/execution/node/346/log

@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14387/7/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14387/7/display/redirect

@grom72 grom72 marked this pull request as ready for review May 21, 2024 06:14
@grom72 grom72 requested a review from a team as a code owner May 21, 2024 06:14
@grom72 grom72 mentioned this pull request May 21, 2024
Open
brianjmurrell
brianjmurrell requested changes May 21, 2024
View reviewed changes
Copy link
Contributor

@brianjmurrell brianjmurrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like what we are after, but let's not land it until we see it working as it's expected to using a calling project. -1 is just until we can confirm that, to prevent an unintentional pre-mature landing.

@grom72
Disable build on Ubuntu
463f246 
Skip-build-ubuntu20-rpm: true

Signed-off-by: Gromadzki, Tomasz <tomasz.gromadzki@intel.com>
@grom72
Copy link
Contributor Author

grom72 commented May 22, 2024

@brianjmurrell please take a look at:
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/ci-daos-stack-go-build-toolchain-PR-25-master/31/parameters/
and confirm that the solution works as you expect.

@brianjmurrell
Copy link
Contributor

@brianjmurrell please take a look at: build.hpdd.intel.com/job/daos-stack/job/daos/job/ci-daos-stack-go-build-toolchain-PR-25-master/31/parameters and confirm that the solution works as you expect.

Excellent work! It does work as expected, for the most part. As we can see in the EL8 RPM build log:

[2024-05-22T15:07:55.555Z] DEBUG util.py:448:   golang                    x86_64  1.22.3-1.daos.el8                    go-build-toolchain:PR-25:16                            53 M

golang is installed from the PR.

It does have the problem however that the Ubuntu build fails because the go-build-toolchain PR does not build for Ubuntu.

It's going to need to however, as Ubuntu has just become an officially supported distro for DAOS 2.8.

That said, this is an inherent problem with CI_PR_REPOS. Unlike the PR-repos[-<distro>]: commit pragmas CI_PR_REPOS doesn't have per-distro control, so the implementation could use commit pragmas for the downstream test instead of setting the parameter.

But I think given that the go-build-toolchain is about the only project that requires the build stage in the downstream job, we can punt on using pragmas instead of parameters and just have go-build-toolchain build for Ubuntu also.

@grom72
Copy link
Contributor Author

grom72 commented May 28, 2024

@brianjmurrell please take a look at: build.hpdd.intel.com/job/daos-stack/job/daos/job/ci-daos-stack-go-build-toolchain-PR-25-master/31/parameters and confirm that the solution works as you expect.

Excellent work! It does work as expected, for the most part. As we can see in the EL8 RPM build log:

[2024-05-22T15:07:55.555Z] DEBUG util.py:448:   golang                    x86_64  1.22.3-1.daos.el8                    go-build-toolchain:PR-25:16                            53 M

golang is installed from the PR.

It does have the problem however that the Ubuntu build fails because the go-build-toolchain PR does not build for Ubuntu.

It's going to need to however, as Ubuntu has just become an officially supported distro for DAOS 2.8.

That said, this is an inherent problem with CI_PR_REPOS. Unlike the PR-repos[-<distro>]: commit pragmas CI_PR_REPOS doesn't have per-distro control, so the implementation could use commit pragmas for the downstream test instead of setting the parameter.

But I think given that the go-build-toolchain is about the only project that requires the build stage in the downstream job, we can punt on using pragmas instead of parameters and just have go-build-toolchain build for Ubuntu also.

Can we somehow split the work as Ubuntu is required for 2.8 but the new go-build-toolchain is required for 2.6?

@brianjmurrell
Copy link
Contributor

Can we somehow split the work as Ubuntu is required for 2.8 but the new go-build-toolchain is required for 2.6?

The problem is that we have no mechanism to skip the Ubuntu build downstream when using CI_PR_REPOS and so every go-build-toolchain PR is going to fail it's downstream testing.

You could switch to using commit pragmas in the downstream testing (there is facility for that -- or almost at least perhaps) but given the simplicity of the packaging for the go-build-toolchain repo, a debian/ dir for it would probably be pretty trivial. There is a ticket already created specifically for that effort, FWIW, as it is going to be necessary sooner than later anyway.

@grom72
Test with WIP pipeline-lib
a08b2f4 
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14387/9/testReport/

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14387/10/testReport/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjmurrell brianjmurrell brianjmurrell requested changes

@JohnMalmberg JohnMalmberg Awaiting requested review from JohnMalmberg

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@grom72 @daosbuild1 @brianjmurrell