DAOS-15151 cart: Cleanup runaway sessions #14386
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Initial version of a '-c' option (cleanup sessions) for self_test. Allows user to terminate all self_test sessions on the specified targets. Intended to be used as a follow-up to an abrupt exit of the previous self_test session. - clang format of self_test.c file Required-githooks: true Signed-off-by: Alexander A Oganezov <alexander.a.oganezov@intel.com>
|
Ticket title is 'DAOS 2.4 - src/cart/crt_self_test_service.c:657 crt_self_test_msg_handler() No self-test buffers available for session ' |
frostedcmos
commented
May 16, 2024
Comment on lines
+977
to
+978
| if (cleanup_sessions) | ||
| close_all_sessions(crt_ctx, srv_grp, endpts, num_endpts); |
There was a problem hiding this comment.
session close code
frostedcmos
commented
May 16, 2024
Comment on lines
+767
to
+770
| static void | ||
| close_all_sessions(crt_context_t cr_ctx, crt_group_t *srv_grp, struct st_endpoint *st_eps, | ||
| int num_eps) | ||
| { |
There was a problem hiding this comment.
new close all sessions client function
frostedcmos
commented
May 16, 2024
Comment on lines
+1718
to
+1720
| case 'c': | ||
| cleanup_sessions = true; | ||
| break; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version of a '-c' option (cleanup sessions) for self_test. Allows user to terminate all self_test sessions on the specified targets. Intended to be used as a follow-up to an abrupt exit of the previous self_test session.
clang format of self_test.c file
Required-githooks: true
Before requesting gatekeeper:
Features:(orTest-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: