Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support public-URL, other than "http://localhost:8080" #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

am-jo-zt
Copy link
Contributor

(cherry picked from commit 039a16f)

@danxfisher
Copy link
Owner

After updating the socket component, I'm not sure I can think of a use case for this. Correct me if I'm wrong, but after thinking about it, the socket will always be listening to localhost:PORT since the frontend and backend will always be hosted/served from the same server.

@am-jo-zt
Copy link
Contributor Author

am-jo-zt commented Jul 23, 2018

Hosted on the same server maybe/probably, but not necessarily loaded on the same device. We had this application deployed to a OpenShift platform and loaded on TV screens across the office. Thus, the host (which was compiled into the code, as far as I can remember) was not localhost, but meeteasier.DOMAIN.com

@danxfisher
Copy link
Owner

Hmm. I have to investigate more. I typically just spin up a Ubuntu VM and test from a few different devices I have laying around the house. Not familiar with OpenShift but this may have something to do with the way it silos the node apps. In the most recent version, I removed the endpoint entirely from the config. Can you see if that works with OpenShift?

@am-jo-zt
Copy link
Contributor Author

Unfortunately this setup does not exist on our side anymore, that's why I can't test this. But as far as I can remember, the URL (including the host) has been compiled into the built sources somewhere and that was not working as we opened the app in the browsers on the TV screens and tried to navigate through it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants