Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PKCE] Enable For Code Grant #61

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

robotarmy
Copy link

Work in Progress:

Goal : config can enable pkce for response_type:code.

TODO:
update schema.
persist code_challenge_method , code_challenge.
process code_verifier before token generation.

@robotarmy
Copy link
Author

@danschultzer Hi!

If you have any thoughts about the direction of this code - let me know!

Also - what version of elixir are you developing with. I have been using erlang 22.0 and elixir 1.9.1.

It would be possible to run elixir-format however I know it will modify the whitespace that has been manually injected in certain areas - Is it tolerable for you to accept elixir-format based auto-format?

Best,

Curtis

@lucacorti
Copy link

Hey, any plan on finishing/merging this? PKCE support would be great.

@chvanikoff
Copy link

@danschultzer please give the PR a look
According to the oAuth 2 Security BCP, PKCE is a requirement, not just recommendation

@danschultzer
Copy link
Owner

According to the oAuth 2 Security BCP, PKCE is a requirement, not just recommendation

Good to know! I'll review this again, and get PKCE support in ASAP.

@deepankar-j
Copy link

@danschultzer, is there any update on this PR? Thanks!

@ericdude4
Copy link
Contributor

@danschultzer any updates here?

@follmann
Copy link

follmann commented Feb 4, 2021

@danschultzer I'd be great to have PKCE support, cheers!

@Ross65536 Ross65536 mentioned this pull request Aug 22, 2021
@Ross65536
Copy link

Ross65536 commented Aug 22, 2021

If anyone is interested I have my own PKCE implementation on my fork while my PR gets reviewed.

EDIT: I'm no longer maintaining my fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants