Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP::SmartyPants #399

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bluebirch
Copy link
Contributor

Added support for PHP::SmartyPants, "a free web typography prettifyier tool for web writers. It easily translates plain ASCII punctuation characters into 'smart' typographic punctuation HTML entities" (https://michelf.ca/projects/php-smartypants/).

This functionality is controlled with the new smart configuration option.

Quotes can be customized and adapted to your preference.

I'm not a PHP developer but a psychologist, so please excuse if my code is slow and ineffective.

@danpros
Copy link
Owner

danpros commented May 6, 2020

Hello,

Thanks for the pull but we should not use it. PHP markdown is enough because PHP Markdown actively developed so it's possible that this feature will be available either.

Not to mention the occurrence of conflict because it is almost the same. https://stackedit.io

@bluebirch
Copy link
Contributor Author

bluebirch commented May 6, 2020

PHP::SmartyPants is from the same developer and is what is recommended if you want to convert quotes and dashes in PHP::Markdown, see for example michelf/php-markdown#144 and michelf/php-markdown#146 (comment).

…ys wanted and I made a mistake in `get_title_from_file`.
@bluebirch
Copy link
Contributor Author

May I bring this feature up for discussion once again?

@danpros
Copy link
Owner

danpros commented Jul 5, 2021

Hello,

Can you make it optional? so we can on and off it via the settings.

@bluebirch
Copy link
Contributor Author

It is optional and turned on with smart = "true" in the configuration. Further customization is possible with doublequote.open, doublequote.close, singlequote.open and singlequote.close.

@vdbhb59
Copy link
Contributor

vdbhb59 commented Jan 8, 2023

This sure sounds like a good option. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants