Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Units to Mbit #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change Units to Mbit #14

wants to merge 1 commit into from

Conversation

dragon2611
Copy link

@dragon2611 dragon2611 commented Jun 8, 2021 •
edited

Change speedtest dashboard to show MegaBits as Value is in Megabits but dashboard was set to Bytes.

Related Issue

#11

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the Code of Conduct
  • I have updated the documentation accordingly.
  • All commits are GPG signed

sinnx3
sinnx3 suggested changes Dec 26, 2022
View reviewed changes
Copy link

@sinnx3 sinnx3 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change from original "Bps" to "bps" (proper Megabit per second formatting)

Incorrect Megabit per second formatting: Bps and decbits.

Reasoning:

Ookla's Speedtest.net measures in Megabits per second by default, not MegaBytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinnx3 sinnx3 sinnx3 requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dragon2611 @sinnx3 @Danne76