🐛 fix: Prevent Node Server Crash Due to Unhandled ChatCompletionMessage Error #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ollama-fix
shortpoet
pushed a commit
to shortpoet/LibreChat
that referenced
this pull request
Dec 30, 2023
…ge Error (danny-avila#1278) * refactor(addTitle): avoid generating title when a request was aborted * chore: bump openai to latest * fix: catch OpenAIError Uncaught error as last resort * fix: handle final messages excludes role=assistant * Update OpenAIClient.js * chore: fix linting errors
cnkang
pushed a commit
to cnkang/LibreChat
that referenced
this pull request
Feb 6, 2024
…ge Error (danny-avila#1278) * refactor(addTitle): avoid generating title when a request was aborted * chore: bump openai to latest * fix: catch OpenAIError Uncaught error as last resort * fix: handle final messages excludes role=assistant * Update OpenAIClient.js * chore: fix linting errors
jinzishuai
pushed a commit
to aitok-ai/LibreChat
that referenced
this pull request
May 20, 2024
…ge Error (danny-avila#1278) * refactor(addTitle): avoid generating title when a request was aborted * chore: bump openai to latest * fix: catch OpenAIError Uncaught error as last resort * fix: handle final messages excludes role=assistant * Update OpenAIClient.js * chore: fix linting errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have implemented a temporary workaround to address a bug in the
openaiNode library where the server crashes due to an unhandledChatCompletionMessageerror when working with reverse proxies or APIs mimicking the OpenAI spec. This bug fix ensures that the server remains stable until theopenailibrary resolves the underlying issue.Closes #1270
FYI I seem to have issues with ollama independent of LibreChat when I don't include --drop_params, related issue: BerriAI/litellm#992 (comment)
With this change I am also prevent title generation if a request was cancelled.
Relevant
openaibug: openai/openai-node#553Change Type
Testing
To test this workaround:
ChatCompletionMessagewith role=assistant is not received.Further testing should be done using different reverse proxy setups to ensure the workaround is robust across various scenarios.
Test Configuration:
Checklist