Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12740 FP redundantCopyLocalConst with pointer member #6410

Merged
merged 2 commits into from
May 21, 2024
Merged

Fix #12740 FP redundantCopyLocalConst with pointer member #6410

merged 2 commits into from
May 21, 2024

Conversation

chrchr-github
Copy link
Collaborator

No description provided.

@chrchr-github
Copy link
Collaborator Author

It seems that bool isVariableChanged(const Variable * var, const Settings &settings, int depth) should not be called on member variables, because then only the class scope is searched.

danmar
danmar approved these changes May 21, 2024
View reviewed changes
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chrchr-github chrchr-github merged commit 7419e53 into danmar:main May 21, 2024
63 checks passed
@chrchr-github chrchr-github deleted the chr_12740 branch May 21, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmar danmar danmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@chrchr-github @danmar