Partial fix for #12697 FN ignoredReturnValue with "pure" and "const" function attributes #6380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
reviewed
May 3, 2024
| @@ -278,7 +278,8 @@ void CheckFunctions::checkIgnoredReturnValue() | |||
| if ((!tok->function() || !Token::Match(tok->function()->retDef, "void %name%")) && | |||
| tok->next()->astOperand1()) { | |||
| const Library::UseRetValType retvalTy = mSettings->library.getUseRetValType(tok); | |||
| const bool warn = (tok->function() && tok->function()->isAttributeNodiscard()) || // avoid duplicate warnings for resource-allocating functions | |||
| const bool warn = (tok->function() && (tok->function()->isAttributeNodiscard() || tok->function()->isAttributePure() || tok->function()->isAttributeConst())) || | |||
There was a problem hiding this comment.
This looks like we were not handling pure function at all previously. So we should also add a unit test for functions which have it specified in a library configuration.
There was a problem hiding this comment.
This change only affects user-declared functions. In the library, we have use-retval. Whether pure should imply use-retval when it is not specified is the topic of https://trac.cppcheck.net/ticket/12696
chrchr-github
force-pushed
the
chr_Fix12697
branch
from
e6b7480
to
7c7d4a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.