compile --rule-file pattern only once / extracted regular expressions code to separate file
#6211
Conversation
|
This is mainly so the issues are reported on start-up instead on each file. It does not improve performance much. The refactoring and improved testing will also make it easier to add support for PCRE2 since PCRE is EOL since quite a while (see https://trac.cppcheck.net/ticket/10610). |
cli/cmdlineparser.cpp
Outdated
| } | ||
|
|
||
| rule.regex = std::make_shared<Regex>(rule.pattern); | ||
| const std::string regex_err = rule.regex->compile(); |
There was a problem hiding this comment.
I am not too happy about this pattern but I could not come up with some without changing the code quite a bit which I wanted to avoid.
lib/settings.h
Outdated
| @@ -293,6 +299,7 @@ class CPPCHECKLIB WARN_UNUSED Settings { | |||
| std::string id = "rule"; // default id | |||
| std::string summary; | |||
| Severity severity = Severity::style; // default severity | |||
| std::shared_ptr<Regex> regex; | |||
There was a problem hiding this comment.
This needs to be a shared pointer because the Settings are being copied (the copies in production code will hopefully go away soon) and we have dynamic memory.
| std::string mPattern; | ||
|
|
||
| class Data; | ||
| std::shared_ptr<Data> mData; |
There was a problem hiding this comment.
This needs to be a shared pointer because the it is used in Settings are they are being copied (the copies in production code will hopefully go away soon) and we have dynamic memory.
This means that multiple threads will use this but as the used data is const there should not be any issues. I did not see anything related to thread safety in the PCRE documentation. I will check again though. I hope any potential issues will be caught by the CI.
Thinking about that we a --rule test which actually has multiple input files. Wil add that.
|
So it seems the shared pointers do not seem to work with forked processes. But there is something else: I wonder where the whitespace in the filename is coming from. |
|
I will split the changes which are are not related to the compilation into a separate PR. |
See #6212. |
firewave
changed the title
--rule-file pattern only once / extracted regular expressions code to separate file / improved errorhandling of --rule and --rule-file=--rule-file pattern only once / extracted regular expressions code to separate file
…ns code to separate file [skip ci]
No description provided.