refactor snet support

[Gioyik]

As part of a university project, I got access to more information related to SNET satellites, this adds and introduces changes in telemetry to get closer to the specification of SNET.

[Gioyik]

I am not sure why the tests are failing, as it seems, they are not related to the changes I made.

[daniestevez]

I think the tests are failing because the satellites Python module cannot be imported due to the changes you made. The error message in the tests is not very helpful, though, but you can check what import satellites says on your machine.

[daniestevez]

It seems that the main change is the addition of a MailboxTelemetry telemetry packet, as an alternative option to ADCSTelemetry and EPSTelemetry. This could be achieved without rewriting this much code, and at the moment I don't see a reason that justifies this rewrite. Can you clarify?

[Gioyik]

@daniestevez I think I addressed most of your comments and requests for changes, could you please give it a check again?

This time, I added an Adapter for the MemData32 and changed the norad values accordingly to this reference: https://web.archive.org/web/20200106160215/http://dk3wn.info:80/blog/satelliten/s-net/

[daniestevez]

Why BitsInteger(32) instead of something like Int32sb?

[Gioyik]

no strong reason why, I have being using Bits* mostly, but Int32sb works too

[daniestevez]

They are not interchangeable. BitsInteger is supposed to operate on a bitwise context, while Int32sb operates on bytes.

>>> Int32sb.build(2)
b'\x00\x00\x00\x02'
>>> BitsInteger(32).build(2)
b'\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x01\x00'

[daniestevez]

By the way, can you share how you're testing this code? The fact that BitsInteger(32) when not inside a bitwise context consumes 32 bytes instead of 4 makes me suspect that your test cases are not good enough.