Fixed crash if color picker left open when control is deallocated.

[Dejal]

For example when switching to another view. The color picker is now
automatically closed, which is a better experience, and avoids the
crash.

[DarkDust]

Removing the notification observer is correct, but we should only reset the panel's target if panel.target == self. Someone might have changed the target of the shared panel.

[Dejal]

There's no getter for the target property, so there's no way to check its value. Elsewhere in the code sets it to nil. Though it's weak linked, so probably don't actually need to reset it.

[Dejal]

Actually, not sure about the weak linking.

[DarkDust]

Oops, it really only is a setter without a getter. How strange. I seems to be weak, just ran a quick test and it didn't increase the retain count of my object (it if weren't, dealloc of DFColorWell wouldn't be called, would it?)

[Dejal]

Strange indeed. I agree that it seems to be weak, so I've removed those two lines. Thanks for the feedback.

[danieljfarrell]

Hmmm mouse events don't work inside the table view. Would making the table view the first responder solve this problem?

[Dejal]

Other mouse events work if you set the highlight mode to None. But the -mouseDown: doesn't work, hence my workaround.

[DarkDust]

Isn't this already solved by merging #10? Or is there something that still needs to be fixed?

[danieljfarrell]

I will take a look. There are merge conflict.

[Dejal]

Sorry, did I accidentally trigger a pull request? I was fixing an issue on my fork of the project: sending the action when setting the default color was overriding my app's settings on High Sierra. See my branch for my changes.