Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bulk.ex with no types #118

Closed
wants to merge 1 commit into from

Conversation

mrnovalles
Copy link

@mrnovalles mrnovalles commented Oct 17, 2023

ElasticSearch 7.x [1] already described the removal of mapping types. For the case of bulk endpoints:

Types should also no longer appear in the body of requests. The following example of bulk indexing omits the type both in the URL, and in the individual bulk commands:

[1] https://www.elastic.co/guide/en/elasticsearch/reference/7.17/removal-of-types.html

This commit removes the /_doc/ part of the URL when making Bulk uploads as part of the hot_swap_index function.

Fixes #113

@lovebes
Copy link

lovebes commented Jan 19, 2024

@danielberkompas Can we merge this in somewhat urgently? Elasticsearch is already at 8.12, and removal of /_doc imho is a change that is due. On a bit of a selfish note I need this at my job ;)

For those that need to use the current url suffix can just use the older version of :elasticsearch.

@lovebes
Copy link

lovebes commented Jan 19, 2024

Actually #106 might be a better approach I think.

@mrnovalles mrnovalles closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants