Remove table-condensed class from table element for each month
#2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect this was leftover from when Bootstrap was a dependency as it doesn't seem to be used by the library anywhere else. If you happen to use this with Bootstrap < 4, it defines a `table-condensed` class which sets some padding on table cells, breaking the design, causing each calendar table to overflow it's container. This could be a breaking change if people customized their use of the library and relied on this class.
|
This should definitely be merged in. I made the exact change in my local file as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect this was leftover from when Bootstrap was a dependency as it doesn't seem to be used by the library anywhere else.
If you happen to use this with Bootstrap < 4, it defines a
table-condensedclass which sets some padding on table cells, breaking the design, causing each calendar table to overflow it's container:https://github.com/twbs/bootstrap/blob/v3.4.1/less/tables.less#L93-L104
This could be a breaking change if people customized their use of the library and relied on this class.