Ignore invalid data from input #2152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When original data in the input is not valid moment.js creates a date object but it is invalid. DateRangePicker then shows the month view filled of NaNs. This change makes DateRangePicker to ignore the input data if it can´t be properly parsed.
But keep in mind that they can be already null.
ahmadsyamim
approved these changes
Nov 6, 2020
kevinpapst
suggested changes
Apr 29, 2021
| @@ -304,6 +304,12 @@ | |||
| start = moment(val, this.locale.format); | |||
| end = moment(val, this.locale.format); | |||
| } | |||
| if (start != null && !start.isValid()) { | |||
There was a problem hiding this comment.
Suggested change
| if (start != null && !start.isValid()) { | |
| if (start !== null && !start.isValid()) { |
| if (start != null && !start.isValid()) { | ||
| start = null; | ||
| } | ||
| if (end != null && !end.isValid()) { |
There was a problem hiding this comment.
Suggested change
| if (end != null && !end.isValid()) { | |
| if (end !== null && !end.isValid()) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When original data in the input is not valid moment.js creates a date object but it is invalid. DateRangePicker then shows the month view filled of NaNs. This change makes DateRangePicker to ignore the input data if it can´t be properly parsed.