Support repository access token on Bitbucket Cloud #1481
Merged
+78
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicmaniac
commented
Feb 9, 2024
| @@ -105,6 +107,12 @@ def fetch_pr_from_branch(branch_name) | |||
| end | |||
|
|
|||
| def fetch_access_token(environment) | |||
| access_token = environment["DANGER_BITBUCKETCLOUD_REPO_ACCESSTOKEN"] | |||
There was a problem hiding this comment.
It is the same environment variable as danger-js.
Most of the documentation comments in this repository has been written in Markdown.
manicmaniac
commented
Feb 9, 2024
| @@ -10,10 +10,31 @@ module Danger | |||
| # | |||
| # ### Token Setup | |||
| # | |||
| # Add `DANGER_BITBUCKETCLOUD_USERNAME` and `DANGER_BITBUCKETCLOUD_PASSWORD` to your pipeline repository variable | |||
| # or instead using `DANGER_BITBUCKETCLOUD_OAUTH_KEY` and `DANGER_BITBUCKETCLOUD_OAUTH_SECRET`. | |||
| # For username and password, you need to set. | |||
There was a problem hiding this comment.
orta
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Close #1463
Test
I added some specs and did integration test on https://bitbucket.org/manicmaniac/danger-examples/pull-requests/1