affine_color_correct docs - code example calling wrong function
#1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaleySchuhl
added
documentation
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
nfahlgren
reviewed
May 17, 2024
| @@ -13,7 +13,7 @@ Euclidean distance between the transformed source color values and the target co | |||
|
|
|||
| - **Parameters:** | |||
| - rgb_img - an RGB image with color chips visualized | |||
| - source_matrix - array of RGB color values (intensity in the range [0-1]) from the image to be corrected where each row is one color reference and the columns are organized as index,R,G,B | |||
| - source_matrix - array of RGB color values (intensity in the range [0-1]) from the image to be corrected where each row is one color reference and the columns are organized as index,R,G,B (likely created with [plantcv.transform.create_color_card_mask](create_color_card_mask.md) or [plantcv.transform.detect_color_card](transform_detect_color_card.md)). | |||
There was a problem hiding this comment.
source_matrix is from pcv.transform.get_color_matrix, using a color card mask
There was a problem hiding this comment.
Ought to be accurate now I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Making affine cc docs more accurate plus adding links to relevant functions
Type of update
Is this a:
Associated issues
Reference associated issue numbers. Does this pull request close any issues?
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md