-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix for roi_type="largest" in roi.filter #1518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaleySchuhl
added
bugfix
Bug fixes
work in progress
Mark work in progress
update
Updates an existing feature/method
labels
May 9, 2024
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
Added different assertions for the unit test. Instead of saying the contour is exactly |
update plotting by using supported cv2 function as they probably planned
HaleySchuhl
added
ready to review
merge in order
Set of PRs that need to be merged sequentially
and removed
work in progress
Mark work in progress
labels
May 13, 2024
nfahlgren
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
Bug fixes
merge in order
Set of PRs that need to be merged sequentially
ready to review
update
Updates an existing feature/method
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updates the way we determine which contour is largest after filtering in
pcv.roi.filter
withroi_type="largest"
setting. Merge this AFTER #1520Type of update
Is this a:
Associated issues
roi_type="largest"
option insidepcv.roi.filter
#1507Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md