Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kmeans tutorial #1512

Merged
merged 5 commits into from May 14, 2024
Merged

Add kmeans tutorial #1512

merged 5 commits into from May 14, 2024

Conversation

k034b363
Copy link
Contributor

@k034b363 k034b363 commented May 2, 2024

Describe your changes
Adding a tutorial for doing kmeans cluster training, classification of a target image, and combining of clusters into binary masks.

Type of update

  • Update to documentation

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@k034b363 k034b363 added documentation Documentation issues or features work in progress Mark work in progress labels May 2, 2024
@k034b363 k034b363 added this to the PlantCV v4.x milestone May 2, 2024
@k034b363 k034b363 added this to Pull Requests in PlantCV4 via automation May 2, 2024
Copy link

deepsource-io bot commented May 2, 2024

Here's the code health analysis summary for commits 7091afc..68b201a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage99.7%99.7%
Line Coverage99.7%99.7%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@k034b363 k034b363 added ready to review and removed work in progress Mark work in progress labels May 2, 2024
@annacasto
Copy link
Contributor

annacasto commented May 2, 2024

Looks good! There was just one spot in cell 8 (I think) where it seems like the comment was unfinished:

# Then, once you have picked the clusters belonging to each category, give mask_kmeans a list:
# Remember, the

@k034b363
Copy link
Contributor Author

k034b363 commented May 2, 2024

Good catch, thank you! I fixed that comment.

@nfahlgren nfahlgren modified the milestones: PlantCV v4.x, PlantCV v4.3 May 14, 2024
@nfahlgren nfahlgren merged commit de60aec into main May 14, 2024
5 checks passed
PlantCV4 automation moved this from Pull Requests to Done May 14, 2024
@nfahlgren nfahlgren deleted the add_kmeans_tutorial branch May 14, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation issues or features ready to review
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants