Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding simple rgb tutorial to the tutorial gallergy #1502

Merged
merged 10 commits into from May 16, 2024

Conversation

annacasto
Copy link
Contributor

@annacasto annacasto commented Apr 22, 2024

Describe your changes
Adding a simple RGB workflow to the tutorial gallery. This tutorial is a straight-forward computer vision workflow and contains references to other workflows with options for more complexity.

Type of update
Is this a:

  • New feature or feature enhancement

Associated issues
None

Additional context

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@annacasto annacasto added documentation Documentation issues or features ready to review labels Apr 22, 2024
Copy link

deepsource-io bot commented Apr 22, 2024

Here's the code health analysis summary for commits 8e34132..f6d1781. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage99.7%99.7%
Line Coverage99.7%99.7%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@annacasto
Copy link
Contributor Author

Keely, I updated the index.ipynb notebook with the optional color correction step, so it should be all set for final review now.

Copy link
Contributor

@k034b363 k034b363 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one typo to fix before the histogram (says "Creating a histogram of pixel insenity"). I also might suggest, since this is supposed to be super basic, that it would be helpful to include something like "you must do math to get the height and width of the ROI".

@annacasto
Copy link
Contributor Author

Fixed typos and added some more context

@annacasto
Copy link
Contributor Author

Fixed the title of the tutorial and added Workflow Inputs

Copy link
Contributor

@HaleySchuhl HaleySchuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WorkflowInputs error resolve with re-running from the top, and maybe extra buttons (since binder is inconsistently functional)


[![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/danforthcenter/plantcv-tutorial-simple-rgb-workflow.git/HEAD) Check out our interactive tutorial!

<iframe src="https://nbviewer.jupyter.org/github/danforthcenter/plantcv-tutorial-simple-rgb-workflow/blob/main/index.ipynb" width="100%" height="1500px"></iframe>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an error on the Workflow_Inputs part, but I believe it just needs to be re-ran and then it'll be good.

@nfahlgren
Copy link
Member

@annacasto could you rerun the notebook and sync it to the tutorial repo? Currently it is rendered with an error:

Screenshot 2024-05-14 at 10 35 22 AM

@nfahlgren nfahlgren dismissed HaleySchuhl’s stale review May 16, 2024 17:08

Changes addressed

@nfahlgren nfahlgren merged commit 1d16aab into main May 16, 2024
5 checks passed
@nfahlgren nfahlgren deleted the adding-simple-rgb-tutorial branch May 16, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation issues or features ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants