New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding simple rgb tutorial to the tutorial gallergy #1502
Conversation
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
Keely, I updated the index.ipynb notebook with the optional color correction step, so it should be all set for final review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just one typo to fix before the histogram (says "Creating a histogram of pixel insenity"). I also might suggest, since this is supposed to be super basic, that it would be helpful to include something like "you must do math to get the height and width of the ROI".
Fixed typos and added some more context |
Fixed the title of the tutorial and added Workflow Inputs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WorkflowInputs error resolve with re-running from the top, and maybe extra buttons (since binder is inconsistently functional)
|
||
[![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/danforthcenter/plantcv-tutorial-simple-rgb-workflow.git/HEAD) Check out our interactive tutorial! | ||
|
||
<iframe src="https://nbviewer.jupyter.org/github/danforthcenter/plantcv-tutorial-simple-rgb-workflow/blob/main/index.ipynb" width="100%" height="1500px"></iframe> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an error on the Workflow_Inputs part, but I believe it just needs to be re-ran and then it'll be good.
@annacasto could you rerun the notebook and sync it to the tutorial repo? Currently it is rendered with an error: |
Describe your changes
Adding a simple RGB workflow to the tutorial gallery. This tutorial is a straight-forward computer vision workflow and contains references to other workflows with options for more complexity.
Type of update
Is this a:
Associated issues
None
Additional context
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md