Debug intermittent testing failures #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
remove xvfb
saw something about specifically using python 3.10.12
seeing if the problem is consistently with 3.10
3.10 isn't the problem. getting same error on 3.11.
omg I broke github actions....
missing comma
add points tests
add centroid tests
napari open
napari classes
napari label classes
testing viewer close on napari classes
testing viewer close
add viewer.close() to napari.open
added napari join labels tests with viewer close
|
added tests back one by one and found that the napari functions need to have viewer.close() after each test (even though the showviewer=false) for tests to run right on github actions, even though they consistently work locally. |
remove some line returns for consistency.
remove verbose and delay
maliagehan
approved these changes
May 16, 2024
There was a problem hiding this comment.
repo continuous integration changed to decrease image size. Also found that we needed to add viewer.close() to tests even though viewer does close locally with no error consistently. Additional small changes were also made that were probably originally unnecessary when we were trying to troubleshoot building the repo. Actions now consistently run. Huzzah
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Changes aimed at debugging the cause of intermittent test failures where pytest exits with null code.
Type of update
Is this a: Work in progress
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md