Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

napari read coor #20

Open
wants to merge 3 commits into
base: 15-add-save-import-napari
Choose a base branch
from
Open

napari read coor #20

wants to merge 3 commits into from

Conversation

maliagehan
Copy link
Member

Describe your changes
Add a Napari Read Coor functions since napari uses y,x format instead of x,y.

Type of update
Is this a:

  • New feature or feature enhancement
  • Update to documentation

Associated issues
#18
Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Apr 19, 2024 •
edited

Here's the code health analysis summary for commits 3eb27ad..730cb8c. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@maliagehan maliagehan added merge in order Set of PRs that need to be merged sequentially ready to review Ready for code review labels Apr 19, 2024
@maliagehan
Copy link
Member Author

Should be merged after PR#17

@maliagehan
yx and xy
6420c17 
changed input names to yx and xy instead of napari and other.
@maliagehan
viewer.close()
730cb8c 
added to check to make sure tests are okay.
@maliagehan maliagehan linked an issue May 16, 2024 that may be closed by this pull request
Napari Import data from get-centroids or from a dictionary of previously selected points #18
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge in order Set of PRs that need to be merged sequentially ready to review Ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Napari Import data from get-centroids or from a dictionary of previously selected points
1 participant
@maliagehan