pdfbox 3 #941
Open
pdfbox 3 #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ken by fractional metrics."" This reverts commit b4ad8b2.
…anti-aliasing on malicious-svg-insecure-mode saucer)
Open
hughsimpson
commented
Sep 6, 2023
| pdFormXObject = layerUtility | ||
| .importPageAsForm(document, pdfpage - 1); | ||
| } | ||
| File file = new File(new URL(url).toURI()); |
There was a problem hiding this comment.
Not sure if there are things this might break.. the input stream api has gone, and the alternative is to read the full byte array, which seems too heavy... OTOH maybe new URL(url).openStream() does some lookup resolution that's invalid for new File(new URL(url).toURI())? I don't really know this part of the java API too well, so any 👀 would be appreciated
|
Awesome! @danfickle Since 3 is officially released, will this be updated as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the 3.0.0 release of pdf box, current openhtmltopdf releases are incompatible. Adding some final compatibility tweaks.