Existing pdf PDDocumentInformation should not be removed #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgalloy
force-pushed
the
do-not-remove-existing-information
branch
from
aae3fd4
to
ff1b725
Compare
Motivation: The method PdfRendererBuilder#usePDDocument(PDDocument) allow the user to provided an existing document. During the process, the information contains in PDDocumentInformation are removed. Modification: * Methods PdfBoxRenderer#setDidValues(PDDocument) add only missing information
vgalloy
force-pushed
the
do-not-remove-existing-information
branch
from
ff1b725
to
5a78dbd
Compare
|
Any news on this subject ? |
|
Hello @danfickle, You seems to be the main contributor to this project. Could you please take look to this PR and tell me if something goes wrong. Regards, Vincent GALLOY |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The method PdfRendererBuilder#usePDDocument(PDDocument) allow the user to provided an existing document. During the process, the information contains in PDDocumentInformation are removed.
Modification: