Bugfix: Updated URL service isCallbackFromSts
#1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect URI if config says to
erichjsonfosse
changed the title
isCallbackFromSts
FabianGosebrink
requested changes
May 9, 2024
projects/angular-auth-oidc-client/src/lib/utils/url/url.service.ts
Outdated
Show resolved
Hide resolved
|
Thanks for this PR, that is looking really nice. Thank you! Can we also update the docs accordingly? |
|
@FabianGosebrink |
docs/site/angular-auth-oidc-client/docs/documentation/configuration.md
Outdated
Show resolved
Hide resolved
FabianGosebrink
approved these changes
May 15, 2024
timdeschryver
approved these changes
May 15, 2024
|
Thanks for helping out here, everyone! Any ETA on an updated package :) ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @damienbod :)
Let me know if I've missed or misunderstood anything.
Also let me know if you want a PR for 17 as well.
I added the option to match current URL to the redirect URI when determining whether or not it's a callback.
Fixes #1935 with backwards compatibility.
Also added a comment in the config interface saying
NB: Default will be true in v18.(for the newcheckRedirectUrlWhenCheckingIfIsCallbackconfig option), as I do think that this should be done, because the default should be to only regard the redirect URI as a possible callback URL.