Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to Angular 17 #1884

Merged
merged 4 commits into from Jan 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc.json
Expand Up @@ -40,7 +40,8 @@
"@typescript-eslint/ban-types": ["error"],
"no-useless-escape": ["error"],
"no-prototype-builtins": ["error"],
"prefer-spread": ["error"]
"prefer-spread": ["error"],
"@typescript-eslint/no-explicit-any": "off"
FabianGosebrink marked this conversation as resolved.
Show resolved Hide resolved
}
},
{
Expand Down
62 changes: 51 additions & 11 deletions .github/workflows/build.yml
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: 16
node-version: 20
FabianGosebrink marked this conversation as resolved.
Show resolved Hide resolved

- name: Installing Dependencies
run: npm ci
Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: 16
node-version: 20

- name: Download Artefact
uses: actions/download-artifact@v2
Expand All @@ -77,7 +77,7 @@ jobs:
path: angular-auth-oidc-client-artefact

- name: Install AngularCLI globally
run: sudo npm install -g @angular/cli@16
run: sudo npm install -g @angular/cli

- name: Show ng Version
run: ng version
Expand Down Expand Up @@ -108,7 +108,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: 16
node-version: 20

- name: Download Artefact
uses: actions/download-artifact@v2
Expand All @@ -117,7 +117,7 @@ jobs:
path: angular-auth-oidc-client-artefact

- name: Install AngularCLI globally
run: sudo npm install -g @angular/cli@16
run: sudo npm install -g @angular/cli

- name: Show ng Version
run: ng version
Expand All @@ -140,15 +140,15 @@ jobs:
working-directory: ./angular-auth-oidc-client-test
run: sudo npm run build

AngularLatestVersionWithStandaloneSchematics:
AngularLatestVersionWithNgModuleSchematics:
FabianGosebrink marked this conversation as resolved.
Show resolved Hide resolved
needs: build_job
runs-on: ubuntu-latest
name: Angular latest Standalone & Schematics Job
steps:
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: 16
node-version: 20

- name: Download Artefact
uses: actions/download-artifact@v2
Expand All @@ -157,13 +157,13 @@ jobs:
path: angular-auth-oidc-client-artefact

- name: Install AngularCLI globally
run: sudo npm install -g @angular/cli@16
run: sudo npm install -g @angular/cli

- name: Show ng Version
run: ng version

- name: Create Angular Project
run: sudo ng new angular-auth-oidc-client-test --skip-git --standalone
run: sudo ng new angular-auth-oidc-client-test --skip-git --standalone=false

- name: Npm Install & Install Library from local artefact
run: |
Expand All @@ -188,7 +188,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: 16
node-version: 20

- name: Download Artefact
uses: actions/download-artifact@v2
Expand All @@ -197,7 +197,7 @@ jobs:
path: angular-auth-oidc-client-artefact

- name: Install AngularCLI globally
run: sudo npm install -g @angular/cli@16
run: sudo npm install -g @angular/cli

- name: Show ng Version
run: ng version
Expand All @@ -224,6 +224,46 @@ jobs:
working-directory: ./angular-auth-oidc-client-test
run: sudo npm run build

LibWithAngularV16:
needs: build_job
runs-on: ubuntu-latest
name: Angular V16
steps:
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: 18

- name: Download Artefact
uses: actions/download-artifact@v2
with:
name: angular_auth_oidc_client_artefact
path: angular-auth-oidc-client-artefact

- name: Install AngularCLI globally
run: sudo npm install -g @angular/cli@16

- name: Show ng Version
run: ng version

- name: Create Angular Project
run: sudo ng new angular-auth-oidc-client-test --skip-git

- name: Npm Install & Install Library from local artefact
run: |
sudo cp -R angular-auth-oidc-client-artefact angular-auth-oidc-client-test/
cd angular-auth-oidc-client-test
sudo npm install --unsafe-perm=true
sudo ng add ./angular-auth-oidc-client-artefact --authority-url-or-tenant-id "my-authority-url" --flow-type "OIDC Code Flow PKCE using refresh tokens" --use-local-package=true --skip-confirmation

- name: Test Angular Application
working-directory: ./angular-auth-oidc-client-test
run: npm test -- --watch=false --browsers=ChromeHeadless

- name: Build Angular Application
working-directory: ./angular-auth-oidc-client-test
run: sudo npm run build

LibWithAngularV15:
needs: build_job
runs-on: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions .vscode/settings.json
@@ -1,7 +1,7 @@
{
"editor.codeActionsOnSave": {
"source.organizeImports": true,
"source.fixAll.eslint": true
"source.organizeImports": "explicit",
FabianGosebrink marked this conversation as resolved.
Show resolved Hide resolved
"source.fixAll.eslint": "explicit"
},
"editor.formatOnSave": true,
"editor.formatOnPaste": true,
Expand Down